Skip to content

docs: Recommend org-level secrets for Warden configuration#18

Merged
dcramer merged 4 commits intomainfrom
feat/cleanup-config
Jan 29, 2026
Merged

docs: Recommend org-level secrets for Warden configuration#18
dcramer merged 4 commits intomainfrom
feat/cleanup-config

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Jan 29, 2026

Update setup guide to be more prescriptive about organization-wide configuration. Recommend setting WARDEN_ANTHROPIC_API_KEY, WARDEN_MODEL, and GitHub App secrets at the org level so all repos share them.

Workflow examples now use env vars instead of action inputs for API key and model, making the configuration cleaner.

Also tightened up language following brand guidelines.

Update setup guide to be more prescriptive about organization-wide
configuration. Recommend setting WARDEN_ANTHROPIC_API_KEY, WARDEN_MODEL,
and GitHub App secrets at the org level so all repos share them.

Workflow examples now use env vars instead of action inputs for API key
and model, making the configuration cleaner.

Also tightened up language following brand guidelines.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
warden Ready Ready Preview, Comment Jan 29, 2026 11:06pm

Request Review

Copy link
Contributor

@sentry-warden sentry-warden bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-review

security-review: Found 1 issue (1 medium)

Co-authored-by: sentry-warden[bot] <258096371+sentry-warden[bot]@users.noreply.github.com>
The env block was incorrectly nested under on.pull_request where it
would be silently ignored. Move it to the job level so the environment
variables are properly available to all steps.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sentry-warden
Copy link
Contributor

sentry-warden bot commented Jan 29, 2026

security-review

security-review: No issues found

No findings to report.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

GitHub Actions substitutes unconfigured secrets with empty strings.
The nullish coalescing operator only treats null/undefined as "not set",
so '' was being passed to the SDK as the model name, causing API errors.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sentry-warden
Copy link
Contributor

sentry-warden bot commented Jan 29, 2026

security-review

security-review: Found 1 issue (1 info)

No findings to report.

@dcramer dcramer merged commit 597ace8 into main Jan 29, 2026
12 checks passed
@dcramer dcramer deleted the feat/cleanup-config branch January 29, 2026 23:15
dcramer added a commit that referenced this pull request Feb 17, 2026
…raction (#156)

When chunks fail to analyze or finding extractions fail, users now see
detailed per-failure information at verbose levels instead of only
aggregate counts in the summary. Add three new events to the reporter spec:
hunk_failed (event #16), extraction_failure (event #17), and retry (event #18).

At Verbose (-v), per-hunk failure details appear inline during skill
execution. At Debug (-vv), extraction failures also show the first 200 chars
of the raw output that failed to parse. The summary now includes a "-v for
failure details" hint when failures are present and verbosity < Verbose.

Wire three existing but unused callbacks through the CLI layer:
- onHunkFailed: fired when SDK analysis fails
- onExtractionFailure: fired when JSON/LLM extraction fails
- onRetry: fired when retry attempts are made

Include failedHunks and failedExtractions in JSONL output for structured
tracking of analysis degradation. Add comprehensive tests covering all
three callback implementations in both TTY and Plain modes.

Update specs/reporters.md with complete documentation of the three new
events, the updated summary section with -v hint, JSONL record changes,
and master checklist updates. Add spec reference comments in source files
so developers know where to find the reporter specification.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dcramer added a commit that referenced this pull request Feb 17, 2026
…raction (#156)

When chunks fail to analyze or finding extractions fail, users now see
detailed per-failure information at verbose levels instead of only
aggregate counts in the summary. Add three new events to the reporter spec:
hunk_failed (event #16), extraction_failure (event #17), and retry (event #18).

At Verbose (-v), per-hunk failure details appear inline during skill
execution. At Debug (-vv), extraction failures also show the first 200 chars
of the raw output that failed to parse. The summary now includes a "-v for
failure details" hint when failures are present and verbosity < Verbose.

Wire three existing but unused callbacks through the CLI layer:
- onHunkFailed: fired when SDK analysis fails
- onExtractionFailure: fired when JSON/LLM extraction fails
- onRetry: fired when retry attempts are made

Include failedHunks and failedExtractions in JSONL output for structured
tracking of analysis degradation. Add comprehensive tests covering all
three callback implementations in both TTY and Plain modes.

Update specs/reporters.md with complete documentation of the three new
events, the updated summary section with -v hint, JSONL record changes,
and master checklist updates. Add spec reference comments in source files
so developers know where to find the reporter specification.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dcramer added a commit that referenced this pull request Feb 18, 2026
…raction (#162)

Surface per-failure details when chunks fail to analyze or finding
extractions fail, enabling users to debug failures without Sentry
access.

Previously, when a chunk failed or an extraction couldn't parse, users
only saw aggregate counts ("1 chunk failed to analyze") in the summary.
This made debugging impossible—they couldn't see which file or line
range failed, what error occurred, or what the raw output was. Operators
had to grep Sentry logs or ask engineers for help.

This PR adds three new events to the reporter spec (events #16–18) that
surface per-failure information at verbose levels:
- **hunk_failed** (event #16): When SDK analysis fails (SDK error, API
error, abort). Shows file:lineRange and error message.
- **extraction_failure** (event #17): When both regex and LLM fallback
fail to extract JSON. At Debug level, also logs the first 200 chars of
the output that failed to parse.
- **retry** (event #18): When a retry attempt is made. Shows attempt
number, max retries, delay, and error.

All three are gated on `Verbosity.Verbose` (enabled with `-v`), keeping
normal output clean. Debug level (`-vv`) adds output previews for
extraction failures.

The "-v for failure details" hint now appears in summaries when failures
are present but verbosity is below Verbose, guiding users to re-run with
verbose output.

Additional improvements:
- JSONL now includes `failedHunks` and `failedExtractions` counts (spec
gap is now closed)
- Spec updated with examples for all three reporters (TTY, Plain, Ink)
and all four verbosity levels
- Comprehensive tests covering both TTY and Plain modes,
Verbose/Debug/Normal verbosity levels

Fixes #156

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant